Clean up unused variables#2268
Clean up unused variables#2268Celandriel wants to merge 6 commits intomod-playerbots:test-stagingfrom
Conversation
|
@brighton-chi @kadeshar Can you review if any signatures of code youve written (strategies) should be modified? I understand not modifying old code, but for strategies youve written, if its not needed, then consider suggesting a change in signature. |
|
Yeah, seems I missed some that weren't needed anymore after I changed stuff around. Definitely can just modify the signatures instead of commenting out. |
|
Also both variables should be deleted from |
|
Conflicts + compilation checks to resolve |
|
Compilation error |
| } | ||
|
|
||
| bool MovementAction::IsMovingAllowed(uint32 mapId, float x, float y, float z) | ||
| bool MovementAction::IsMovingAllowed(uint32 /*mapId*/, float /*x*/, float /*y*/, float /*z*/) |
There was a problem hiding this comment.
This parameters should be removed not commented
| } | ||
|
|
||
| bool MovementAction::IsDuplicateMove(uint32 mapId, float x, float y, float z) | ||
| bool MovementAction::IsDuplicateMove(uint32 /*mapId*/, float x, float y, float z) |
There was a problem hiding this comment.
This parameter should be removed not commented
| } | ||
|
|
||
| bool MovementAction::ChaseTo(WorldObject* obj, float distance, float angle) | ||
| bool MovementAction::ChaseTo(WorldObject* obj, float distance, float /*angle*/) |
There was a problem hiding this comment.
This parameter should be removed not commented
| } | ||
|
|
||
| void ReleaseSpiritAction::LogRelease(const std::string& releaseMsg, bool isAutoRelease) const | ||
| void ReleaseSpiritAction::LogRelease(const std::string& releaseMsg, bool /*isAutoRelease*/) const |
There was a problem hiding this comment.
This parameter should be removed not commented
| } | ||
|
|
||
| void ChatReplyAction::ChatReplyDo(Player* bot, uint32& type, uint32& guid1, uint32& guid2, std::string& msg, std::string& chanName, std::string& name) | ||
| void ChatReplyAction::ChatReplyDo(Player* bot, uint32& type, uint32& guid1, uint32& /*guid2*/, std::string& msg, std::string& chanName, std::string& name) |
There was a problem hiding this comment.
This parameter should be removed not commented
Check rest for same.
|
It was said last time we did this thag we should try to avoid editing the signatures. |
|
Like before im against such fixes #2106. That only hide real problem and not fix anything. Claming that are maybe required to production solution also doesnt make sense. Then comment not only name but also type. When will be required on production solution someone only uncomment them. But im almost certain that will never happen xD |
Pull Request Description
Clean up a bunch of additional unused variable warnings.
Feature Evaluation
How to Test the Changes
Impact Assessment
Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?
Does this change modify default bot behavior?
Does this change add new decision branches or increase maintenance complexity?
Messages to Translate
AI Assistance
Claude reviewed the warnings log from a build and suggested a series of changes. I focused just on these warnings for now. Every line was reviewed. Some sections need to be reviewed by author for intent.
Final Checklist
Notes for Reviewers