Skip to content

Worldbuff classic support#2311

Merged
Celandriel merged 3 commits intomod-playerbots:test-stagingfrom
kadeshar:worldbuff-classic-support
Apr 17, 2026
Merged

Worldbuff classic support#2311
Celandriel merged 3 commits intomod-playerbots:test-stagingfrom
kadeshar:worldbuff-classic-support

Conversation

@kadeshar
Copy link
Copy Markdown
Collaborator

@kadeshar kadeshar commented Apr 15, 2026 •
edited
Loading

Pull Request Description

Added support for flask and food for vanilla and TBC

Vanilla

Class Spec Buff IDs Buffs
Warrior Arms 17538, 24799 Elixir of the Mongoose; Smoked Desert Dumplings
Warrior Fury 17538, 24799 Elixir of the Mongoose; Smoked Desert Dumplings
Warrior Protection 17626, 25661 Flask of the Titans; Dirge's Kickin' Chimaerok Chops
Paladin Holy 17627, 18194 Flask of Distilled Wisdom; Nightfin Soup
Paladin Protection 17626, 25661 Flask of the Titans; Dirge's Kickin' Chimaerok Chops
Paladin Retribution 17628, 24799 Flask of Supreme Power; Smoked Desert Dumplings
Hunter Beast Mastery 17538, 18192 Elixir of the Mongoose; Grilled Squid
Hunter Marksmanship 17538, 18192 Elixir of the Mongoose; Grilled Squid
Hunter Survival 17538, 18192 Elixir of the Mongoose; Grilled Squid
Rogue Assassination 17538, 18192 Elixir of the Mongoose; Grilled Squid
Rogue Combat 17538, 18192 Elixir of the Mongoose; Grilled Squid
Rogue Subtlety 17538, 18192 Elixir of the Mongoose; Grilled Squid
Priest Discipline 17628, 18194 Flask of Supreme Power; Nightfin Soup
Priest Holy 17627, 18194 Flask of Distilled Wisdom; Nightfin Soup
Priest Shadow 17628, 18194 Flask of Supreme Power; Nightfin Soup
Shaman Elemental 17628, 18194 Flask of Supreme Power; Nightfin Soup
Shaman Enhancement 17538, 24799 Elixir of the Mongoose; Smoked Desert Dumplings
Shaman Restoration 17627, 18194 Flask of Distilled Wisdom; Nightfin Soup
Mage Arcane 17628, 18194 Flask of Supreme Power; Nightfin Soup
Mage Fire 17628, 18194 Flask of Supreme Power; Nightfin Soup
Mage Frost 17628, 18194 Flask of Supreme Power; Nightfin Soup
Warlock Affliction 17628, 25661 Flask of Supreme Power; Dirge's Kickin' Chimaerok Chops
Warlock Demonology 17628, 25661 Flask of Supreme Power; Dirge's Kickin' Chimaerok Chops
Warlock Destruction 17628, 25661 Flask of Supreme Power; Dirge's Kickin' Chimaerok Chops
Druid Balance 17628, 18194 Flask of Supreme Power; Nightfin Soup
Druid Feral Bear 17626, 25661 Flask of the Titans; Dirge's Kickin' Chimaerok Chops
Druid Restoration 17627, 18194 Flask of Distilled Wisdom; Nightfin Soup
Druid Feral Cat 17538, 24799 Elixir of the Mongoose; Smoked Desert Dumplings

TBC

Class Spec Buff IDs Buffs
Warrior Arms 28520, 33256 Flask of Relentless Assault; Roasted Clefthoof
Warrior Fury 28520, 33256 Flask of Relentless Assault; Roasted Clefthoof
Warrior Protection 28518, 33257 Flask of Fortification; Fisherman's Feast
Paladin Holy 28491, 39627, 33263 Elixir of Healing Power; Elixir of Draenic Wisdom; Blackened Basilisk
Paladin Protection 28518, 33257 Flask of Fortification; Fisherman's Feast
Paladin Retribution 28520, 33256 Flask of Relentless Assault; Roasted Clefthoof
Hunter Beast Mastery 28520, 33261 Flask of Relentless Assault; Warp Burger
Hunter Marksmanship 28520, 33261 Flask of Relentless Assault; Warp Burger
Hunter Survival 28520, 33261 Flask of Relentless Assault; Warp Burger
Rogue Assassination 28520, 33261 Flask of Relentless Assault; Warp Burger
Rogue Combat 28520, 33261 Flask of Relentless Assault; Warp Burger
Rogue Subtlety 28520, 33261 Flask of Relentless Assault; Warp Burger
Priest Discipline 28491, 39627, 33263 Elixir of Healing Power; Elixir of Draenic Wisdom; Blackened Basilisk
Priest Holy 28491, 39627, 33263 Elixir of Healing Power; Elixir of Draenic Wisdom; Blackened Basilisk
Priest Shadow 28540, 33263 Flask of Pure Death; Blackened Basilisk
Shaman Elemental 28521, 33263 Flask of Blinding Light; Blackened Basilisk
Shaman Enhancement 28520, 33261 Flask of Relentless Assault; Warp Burger
Shaman Restoration 28491, 39627, 33263 Elixir of Healing Power; Elixir of Draenic Wisdom; Blackened Basilisk
Mage Arcane 28521, 33263 Flask of Blinding Light; Blackened Basilisk
Mage Fire 28540, 33263 Flask of Pure Death; Blackened Basilisk
Mage Frost 28540, 33263 Flask of Pure Death; Blackened Basilisk
Warlock Affliction 28540, 33263 Flask of Pure Death; Blackened Basilisk
Warlock Demonology 28540, 33263 Flask of Pure Death; Blackened Basilisk
Warlock Destruction 28540, 33263 Flask of Pure Death; Blackened Basilisk
Druid Balance 28521, 33263 Flask of Blinding Light; Blackened Basilisk
Druid Feral Bear 28518, 33257 Flask of Fortification; Fisherman's Feast
Druid Restoration 28491, 39627, 33263 Elixir of Healing Power; Elixir of Draenic Wisdom; Blackened Basilisk
Druid Feral Cat 28520, 33261 Flask of Relentless Assault; Warp Burger

How to Test the Changes

  1. Invite bot with 60-79 level
  2. Add him strategy nc +worldbuff
  3. Bot should apply buffs

Impact Assessment

  • Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?

      • No, not at all
      • Minimal impact (explain below)
      • Moderate impact (explain below)

  • Does this change modify default bot behavior?

      • No
      • Yes (explain why)

  • Does this change add new decision branches or increase maintenance complexity?

      • No
      • Yes (explain below)

AI Assistance

Was AI assistance used while working on this change?

    • No
    • Yes (explain below)

Prepare list of buffs based on website and apply them to matrix.
Randomly reviewed ids with guides and in-game

Final Checklist

    • Stability is not compromised.
    • Performance impact is understood, tested, and acceptable.
    • Added logic complexity is justified and explained.
    • Any new bot dialogue lines are translated.
    • Documentation updated if needed (Conf comments, WiKi commands).

Notes for Reviewers

VANILLA_CONSUMABLE_WORLD_BUFFS.md
TBC_CONSUMABLE_WORLD_BUFFS.md

@brighton-chi
Copy link
Copy Markdown
Contributor

brighton-chi commented Apr 16, 2026

Thoughts for TBC:

  • Fire and Frost Mage want Flask of Pure Death
  • Bear should use Flask of Fortification. WotLK destroyed their agi to dodge conversion rate
  • Holy Paladin would prefer Elixir of Healing Power and Elixir of Draenic Wisdom
  • Warp Burger is better for Enhancement Shaman due to WotLK changes (Shamans used to get 2 AP/str and 0 AP/agi in TBC)
  • Blackened Basilisk, Crunchy Serpent, and Golden Fishsticks all do the same thing. Maybe we can just use the same aura for simplicity
  • Spicy Crawdad and Fisherman's Feast do the same thing. Maybe we just use the same one

@kadeshar
Copy link
Copy Markdown
Collaborator Author

kadeshar commented Apr 16, 2026

Changed

@Celandriel Celandriel merged commit 665a702 into mod-playerbots:test-staging Apr 17, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Celandriel Celandriel Celandriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kadeshar @brighton-chi @Celandriel