NODE-2253: Support for v1 Extended JSON#339
Merged
Conversation
- Adds a legacy: true option to serialize and stringify - Adds tests for cases where v1 and v2 extjson differ.
474eb4d to
4843287
Compare
imlucas
suggested changes
Dec 16, 2019
Contributor
imlucas
left a comment
There was a problem hiding this comment.
LGTM with update to docs in README
34 tasks
mbroadst
suggested changes
Jan 6, 2020
| : Buffer.from(this.buffer).toString('base64'); | ||
|
|
||
| const subType = Number(this.sub_type).toString(16); | ||
| if (options.legacy) { |
Member
There was a problem hiding this comment.
I think we need to ensure options exists, otherwise you'll have an error on trying to access legacy on it. Recommend:
typeof options !== 'undefined' && options.legacy- adding a
options = options || {}above - make some helper function to check this, since its likely you are doing it many places
I realize this may be an existing issue prior to the changes introduced here, but this PR would necessarily introduce such a bug into every method now.
Contributor
mbroadst
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
legacy: trueoption toserialize,deserialize,parse, andstringify.