This repository was archived by the owner on Sep 7, 2021. It is now read-only.
Fixes for Windows-specific compilation issues#2
Merged
montegoulding merged 2 commits intomontegoulding:feature/gypify_lcidlfrom Oct 8, 2015
Merged
Conversation
On Windows, Gyp is sometimes too eager in interpreting arguments to scripts as paths rather than literals. As I've not been able to track down the source of this issue, a work-around in the affected script is required.
montegoulding
pushed a commit
that referenced
this pull request
Oct 8, 2015
Fixes for Windows-specific compilation issues
There was a problem hiding this comment.
Perhaps an explanation should be included as a comment in the script. This looks pretty odd otherwise.
Author
There was a problem hiding this comment.
Quite right! That's what happens when I decide to turn my quick-fix into a PR ;)
Owner
There was a problem hiding this comment.
I'll add something to save you doing it @livecodefraser ... I've already merged the PR ;-)
montegoulding
pushed a commit
that referenced
this pull request
Oct 7, 2016
[[Dictionary]] item/last/lines/long/me variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Windows compilation failures encountered when CI-testing livecode#3017.