Merged
Conversation
Remove mock module to avoid collision with builtin mock module name. Moved Client class inside into agithub_test
Fix package URL
…ded version Change VERSION constant from semver list (e.g. [2, 2, 1]) to string version (e.g. 2.2.1) Remove STR_VERSION constant
This doesn't yet mock the response from GitHub, it makes a live call This call could be ratelimited or fail due to transient network issues Once we switch to using requests we'll want to mock out this GitHub response
Update CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Changed
Removed
Fixed
Trueandsleep_on_ratelimitis the default (Removed lower() on reading rate-limit header #66 by @huma23)