Skip to content

chore: prepare java-spanner for (22.3.0) upgrade #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mpeddada1 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: prepare java-spanner for (22.3.0) upgrade #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d63b0
chore: prepare java-spanner for (22.3.0) upgrade
mpeddada1 Dec 29, 2022
0dfbe6e
add slf4j logging library
mpeddada1 Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-spanner-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-config</artifactId>
<version>1.5.5</version>
<version>1.5.6-SNAPSHOT</version>
</parent>

<name>Google Cloud Spanner BOM</name>
Expand Down
5 changes: 5 additions & 0 deletions google-cloud-spanner/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@

<dependencies>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-jdk14</artifactId>
<version>2.0.3</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>grpc-gcp</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/v1/SpannerClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,20 @@
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@Generated("by gapic-generator-java")
public class SpannerClientTest {
private static final Logger LOGGER = LoggerFactory.getLogger(SpannerClientTest.class);
private static MockServiceHelper mockServiceHelper;
private static MockSpanner mockSpanner;
private LocalChannelProvider channelProvider;
private SpannerClient client;

@BeforeClass
public static void startStaticServer() {
LOGGER.info("Testing logging in Storage integration tests");
mockSpanner = new MockSpanner();
mockServiceHelper =
new MockServiceHelper(
Expand All @@ -110,6 +114,7 @@ public static void stopServer() {

@Before
public void setUp() throws IOException {
LOGGER.info("Testing logging in Storage setup method");
mockServiceHelper.reset();
channelProvider = mockServiceHelper.createChannelProvider();
SpannerSettings settings =
Expand All @@ -127,6 +132,7 @@ public void tearDown() throws Exception {

@Test
public void createSessionTest() throws Exception {
LOGGER.info("Testing logging in createSessionTest");
Session expectedResponse =
Session.newBuilder()
.setName(
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-config</artifactId>
<version>1.5.5</version>
<version>1.5.6-SNAPSHOT</version>
</parent>

<developers>
Expand Down Expand Up @@ -54,7 +54,7 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<github.global.server>github</github.global.server>
<site.installationModule>google-cloud-spanner-parent</site.installationModule>
<google.cloud.shared-dependencies.version>3.1.0</google.cloud.shared-dependencies.version>
<google.cloud.shared-dependencies.version>3.1.1-SNAPSHOT</google.cloud.shared-dependencies.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -98,7 +98,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-dependencies</artifactId>
<version>${google.cloud.shared-dependencies.version}</version>
<version>3.1.1-SNAPSHOT</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down