Skip to content

UofT-DSI | Python - Assignment 2#2

Open
mprezlyata wants to merge 2 commits intomainfrom
assignment-2
Open

UofT-DSI | Python - Assignment 2#2
mprezlyata wants to merge 2 commits intomainfrom
assignment-2

Conversation

@mprezlyata
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments to your Pull request
Q3: The function detect_problems should return True/False according to the requirements. Please correct and re-submit

@mprezlyata
Copy link
Copy Markdown
Owner Author

What changes are you trying to make?
Define the patient_summary and detect_problems functions.
What did you learn from the changes you have made?
How to read and display data from the file, work with arrays, and use the NumPy package.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I thought it would be more convenient for users if the 'detect_problems' function displayed the message 'Patient in your dataset has an average inflammation score of 0. Please check the file.' or 'No patients with an average inflammation score of 0 were found.' instead of True or False.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
The changes were tested by running the code in the VS Code on my computer.
A reference to a related issue in your repository (if applicable)
Checklist
I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed now. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants