Merged
Conversation
Member
hasumikin
commented
Feb 22, 2026
- autogen files are created in rake, so making them in host container in advance is not necessary
The src/ directory is mounted from the host in Docker-based CI, so it is owned by the runner user and not writable by the container user. Moving the output to build/ avoids permission conflicts because Docker creates build/ fresh and owns it. - Add -I$(BUILD_DIR) to CFLAGS so headers are found by the compiler. - Add --output-dir option to make_method_table.rb. - Accept an optional output path argument in generate_unicode_case_tables.rb. - Simplify the autogen Make target: drop rm -f and mkdir -p $(BUILD_DIR). - clean_all now just delegates to clean (autogen files are in build/). - Update autogen.yml to copy from build/ when packaging release archives. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.