Merged
Conversation
Implements Hash#fetch(key[, default]) which raises an error when a key is missing and no default is given.
Member
|
@khasinski |
Contributor
Author
|
@hasumikin Thank you for the review! I added tests for Please take your time to discuss with the team. Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Hash#fetch(key[, default])method.This is useful for reading configuration values safely. When a required key is missing and no default is given,
fetchraises an error instead of returningnilsilently. This helps catch mistakes early.Supports
KeyErrorsemantics (raisesRuntimeErrorsinceKeyErroris not available in mruby/c).Changes
c_hash_fetchfunction insrc/c_hash.cfetchmethod in Hash class