Merged
Conversation
Verify that the import mechanism supports embedding messages from one protocol as field types in another (not just cross-file extends). Two proto files: shared.proto defines Address/Coordinate, composite.proto imports them and uses them as fields in Person and DeliveryOrder. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Add a `json` primitive type to msgbuf that represents an opaque JSON value. In JSON format, the value is written natively without string-wrapping. For binary serialization, values are wrapped in a JsonValue message hierarchy (JsonString, JsonLong, JsonDouble, JsonBoolean, JsonNull, JsonArray, JsonObject). Also fixes a pre-existing bug where map fields were not serialized in binary format (binaryWriteValue had a TODO for MapType). Closes #11 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
8250da2 to
dbcdd21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11