Replacing calls to Exception#printStackTrace() with Java logging.#139
Replacing calls to Exception#printStackTrace() with Java logging.#139komamitsu merged 3 commits intomsgpack:masterfrom
Exception#printStackTrace() with Java logging.#139Conversation
This will keep output cleaner, especially in Android where logging and stdout are mixed.
There was a problem hiding this comment.
I'm puzzled by this formatting; the file itself seems to have proper indentation. Perhaps my local git configuration is to blame...
|
Thanks for your contribution, @benjamin-bader. It looks good to me. @komamitsu, could you check this issue? |
|
@benjamin-bader I noticed that the original Also, we can output the stack trace of a Throwable using Originally, that error message is important and I think we should've outputted it as a higher log level with its stack trace... After all, something like the following code seems better to me. What do you think? |
|
@komamitsu Sounds good, thank you for the feedback. I'll fix and update today. |
Additionaly, increase log level of exceptions from FINE to WARNING.
Replacing calls to `Exception#printStackTrace()` with Java logging.
|
@benjamin-bader Sorry for my delay and thanks for your contribution! |
|
Thank you @komamitsu! I had assumed this section of the codebase was obsolete in the upcoming 0.7 release - glad to hear that this may still be useful. |
This will keep output cleaner, especially in Android where logging and stdout are mixed.