Skip to content

make it work when there's a dot in the attribute selector#30

Merged
wscherphof merged 1 commit intomsva:masterfrom
ljie-PI:master
Jan 8, 2014
Merged

make it work when there's a dot in the attribute selector#30
wscherphof merged 1 commit intomsva:masterfrom
ljie-PI:master

Conversation

@ljie-PI
Copy link
Copy Markdown
Contributor

@ljie-PI ljie-PI commented Dec 22, 2013

Hi Wouter,

Thank you for making this htmlparser. But I got a issue when using attribute selector "[src='aaa.jpg']" to select a node. It seems that the dot in the jpg file caused it. So I try to work around this issue.

If you think that my code style is bad, please feel free to change the code. But I really want this feature supported in this library.

Thanks,
Rocky

@ljie-PI
Copy link
Copy Markdown
Contributor Author

ljie-PI commented Dec 26, 2013

Hi Wouter,

Is there any update on this feature?

Thanks,
Rocky

@wscherphof
Copy link
Copy Markdown
Collaborator

Sorry, missed the email while on holiday. Will look into it.

wscherphof added a commit that referenced this pull request Jan 8, 2014
make it work when there's a dot in the attribute selector
@wscherphof wscherphof merged commit a021c46 into msva:master Jan 8, 2014
wscherphof pushed a commit that referenced this pull request Jan 9, 2014
Releasing the fix allowing a `.` in attribute values in selector
strings (#30)
This was referenced Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants