Move project configuration to pyproject.toml#26
Conversation
maarten-ic
commented
Apr 9, 2026
- Migrate configuration from setup.py, setup.cfg and .coveragerc to pyproject.toml
- Replace flake8 with ruff (with E and F lints enabled)
- Migrate configuration from setup.py, setup.cfg and .coveragerc to pyproject.toml - Replace flake8 with ruff (with E and F lints enabled)
|
Notes:
|
LourensVeen
left a comment
There was a problem hiding this comment.
Nice! I have one discussion point.
| types-PyYAML | ||
|
|
||
| commands = | ||
| ruff check |
There was a problem hiding this comment.
I had flake8 at the end because when I'm debugging, I often comment things out in not quite the right way or end up with an overly long line with a debug print statement, and it's quite annoying if the tests then don't run because tox already quits on the linting step.
I guess that doesn't happen if you run an autoformatter in your editor, but is there a reason to put it first?
There was a problem hiding this comment.
My reasoning was: ruff is the fastest of the three, so putting it first will give feedback sooner (and waste less time and resources on the more expensive tests).
Though I don't mind putting it at the end if that helps your workflow :)