Skip to content

Completion of Assignment 2 for the python module#3

Open
mychellew wants to merge 1 commit intomainfrom
assignment-2
Open

Completion of Assignment 2 for the python module#3
mychellew wants to merge 1 commit intomainfrom
assignment-2

Conversation

@mychellew
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I am adding code to Assignment 2 which will provide the logic and functionality to preview data and to complete basic summary statistics and QA/QC of the data.

What did you learn from the changes you have made?

I learned more about the available methods available in the numpy python package more specifically loadtxt and how to use for loops to automate processing on previewing files.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I considered using a for loop for patient_summary but was able to gain more clarity on what the function loadtxt does to the data that is provided to the function. This was able to simplify the code.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Understanding the goals of what you are trying to achieve in the code is very important when trying to develop code. Communicating and ensuring mutual understanding of what you are trying to do is very important. Additionally, you want to ensure that there are no gaps in the logic, ensuring you are covering possible scenarios is important in building your code. One way of testing if my code was functioning as expected was creating another patient file that we know should produce the result of True.

How were these changes tested?

I created additional test data to test my scripts.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Love the docstring for documentation. Also, I like testing that you did for the function. Note: the output block for the last block should only display 'False'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants