Completion of Assignment 2 for the python module#3
Open
Conversation
anjali-deshpande-hub
approved these changes
Dec 10, 2024
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Well done! Love the docstring for documentation. Also, I like testing that you did for the function. Note: the output block for the last block should only display 'False'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I am adding code to Assignment 2 which will provide the logic and functionality to preview data and to complete basic summary statistics and QA/QC of the data.
What did you learn from the changes you have made?
I learned more about the available methods available in the numpy python package more specifically loadtxt and how to use for loops to automate processing on previewing files.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered using a for loop for patient_summary but was able to gain more clarity on what the function loadtxt does to the data that is provided to the function. This was able to simplify the code.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Understanding the goals of what you are trying to achieve in the code is very important when trying to develop code. Communicating and ensuring mutual understanding of what you are trying to do is very important. Additionally, you want to ensure that there are no gaps in the logic, ensuring you are covering possible scenarios is important in building your code. One way of testing if my code was functioning as expected was creating another patient file that we know should produce the result of True.
How were these changes tested?
I created additional test data to test my scripts.
A reference to a related issue in your repository (if applicable)
Checklist