I'm fine with moving the creation of /etc/nbfc into a separate step, but it shouldn't be a part of the normal makefile install target as it is a step which touches the system configuration and that should be only relegated to package maintainers and users that are manually installing the service.

Hello @nikp123,

thank you for contributing.

You are right, creating /etc/nbfc in the Makefile is a bad idea, so removing those lines from the Makefiles is the right approach.

However, I disagree with renaming the package from nbfc-linux to nbfc, as the "orignal project" is already named nbfc.

Also, I noticed the configureFlags where you hard-code /etc. I remember this being an issue back when NBFC-Linux still wrote the fan speeds to /etc/nbfc/nbfc.json. These days NBFC-Linux writes the fan speed state to a state file under /var/lib/nbfc, but tools like nbfc-qt and nbfc-gtk still write to /etc/nbfc/nbfc.json (or wherever the main config is stored) for configuring things.

(The reason I'm bringing this up is because I remember NixOS having a kind of "static" filesystem where you can't modify files in e.g. /etc. Please correct me if I'm wrong.)

So:

• Rename the package back to nbfc-linux
• (Maybe) revert the --sysconfdir=/etc

Best regards,

Benjamin

Thanks for the feedback.
Reverting the --sysconfdir=/etc will break the package as nbfc will not start with the etc folder being inside of the Nix store.

(The reason I'm bringing this up is because I remember NixOS having a kind of "static" filesystem where you can't modify files in e.g. /etc. Please correct me if I'm wrong.)

Yes and no. Most Nix packages don't write to /etc directly, however it's not strictly forbidden.
One example is NetworkManager which both reads and writes to /etc/NetworkManager, even inside of NixOS.
However, through the use of options you can make NixOS generate files in your /etc directory, that's probably what you meant, right?

This just offers the option for someone to manually configure the package and then later upgrade to a generated config via NixOS options if they so choose.

However, I have no issue with reverting the name as it was, I didn't think the nbfc-linux was the intended name. Apologies on that. Will be bringing that back shortly.

does this work past this commit 7960a1d
I was overriding the flake using

  nixpkgs.overlays = [
    (finaln: oldn: {
      nbfc-linux = inputs.nbfc-linux.packages.x86_64-linux.default.overrideAttrs (final: old: {
        preFixup = "";
        nativeBuildInputs = old.nativeBuildInputs ++ [pkgs.curl];
      });
    })
  ];

if this is still working with latest commit
can it be merged
and best regards
and thanks for the amazing project

@bohanubis I have updated the remote to a newer version. I haven't ran the program, but I've made sure it builds. The problem was that reverse_nxjson.h got included in Makefile.in that doesn't exist which broke the build. I removed that reference from there and the build now works.

@nikp123 I can confirm it works thanks a lot
I hope this gets merged soon