#551 Adds Docker support#552
Merged
x4v13r64 merged 1 commit intonccgroup:developfrom Oct 15, 2019
duck-nukem:feature/551-docker-support
Merged
#551 Adds Docker support#552x4v13r64 merged 1 commit intonccgroup:developfrom duck-nukem:feature/551-docker-support
x4v13r64 merged 1 commit intonccgroup:developfrom
duck-nukem:feature/551-docker-support
Conversation
Collaborator
|
@thommor could you have a look please? |
thommor
approved these changes
Oct 14, 2019
Contributor
thommor
left a comment
There was a problem hiding this comment.
This Dockerfile looks fine to me.
@j4v One of the tests is failing but I cant see this being caused by the Dockerfile, can you confirm?
FAIL: test_composite_resource (test-resources.TestResources)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/nccgroup/ScoutSuite/tests/test-resources.py", line 55, in test_composite_resource
assert (expected_json == actual_json)
The wiki will need updating
Collaborator
re-ran the tests and it went fine - for some reason builds sometime fail...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 this is the proposed Dockerfile - unfortunately couldn't use an alpine based image, this is the second smallest I could find.
Not sure if I can include changes for the wiki, but this should be the way of installing & running ScoutSuite with Docker:
Install
docker build -t scoutsuite:latest .Run
If you'd like to add further clarification to these commands, it will:
ttyflag, and the container will be removed once it finishes/Users/me/.aws(where/Users/meshould be changed to the home directory of whoever runs it) so the aws creds are available from within the container.scoutsuite:latest) you just pass in arguments as you normally would to the script itself