[ PATCH ] OpenAI computer use#107
Open
AhmedShriefNeferdata wants to merge 1 commit intomainfrom
Open
Conversation
kamillitman
reviewed
Apr 10, 2026
Comment on lines
+135
to
+141
| impl Default for OpenAIComputerUseConfig { | ||
| fn default() -> Self { | ||
| Self { | ||
| tool_type: OpenAIComputerUseToolType::Computer, | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
You don't need to implement this. Since you already have Default derived at OpenAIComputerUseToolType and have defined Computer as the default variant, all you need to do is derive Default for OpenAIComputerUseConfig.
kamillitman
reviewed
Apr 10, 2026
| } | ||
|
|
||
| #[derive(Deserialize, Serialize, Debug, Clone, Eq, PartialEq)] | ||
| pub struct OpenAIComputerCall { |
Contributor
There was a problem hiding this comment.
How are these used? They only seem to be defined but not actually used in code.
Contributor
There was a problem hiding this comment.
I think we will need to modify llms::openai::get_version_data:
allms/src/llm_models/openai.rs
Line 783 in ca24b2b
If the user is calling Responses API and attached the computer use tool, we will need to parse the response into your new types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.