Check if context_scope includes .settings.views#602
Merged
DouweM merged 1 commit intonesquena:masterfrom Dec 5, 2014
LTe:sinatra-faked
Merged
Check if context_scope includes .settings.views#602DouweM merged 1 commit intonesquena:masterfrom LTe:sinatra-faked
.settings.views#602DouweM merged 1 commit intonesquena:masterfrom
LTe:sinatra-faked
Conversation
When Sinatra is defined rabl assume that `context_scope` is from Sinatra. We need to check that context_scope includes whole path.
DouweM
added a commit
that referenced
this pull request
Dec 5, 2014
Check if context_scope includes `.settings.views`
Collaborator
|
Whoops, jumped the gun on closing there. Merged! |
Collaborator
|
@nesquena time for another release? |
Owner
|
@DouweM pushed 0.11.5, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Sinatra is defined rabl assume that
context_scopeis fromSinatra. We need to check that context_scope includes whole path.
Related: #597