Change array to string when rack response part is kind of Array#32
Closed
LTe wants to merge 2 commits intonewrelic:masterfrom
LTe:array_path
Closed
Change array to string when rack response part is kind of Array#32LTe wants to merge 2 commits intonewrelic:masterfrom LTe:array_path
LTe wants to merge 2 commits intonewrelic:masterfrom
LTe:array_path
Conversation
Contributor
|
Thanks for the commit, Piotr. Can you elaborate on why this is necessary? According to the Rack spec the fragments must already be strings. |
|
This may only be indirectly related but we've identified an issue where the fragments arrive at this point as an Array which is causing a large number of failed requests for us. Based on your statement about the Rack spec, this would indicate the problem is higher in the stack. This may have prompted LTe's initial pull request. FYI. |
Contributor
|
Thanks for the contributions! I'm closing this pull request. It seems like the agent's current behavior is correct, based on the Rack spec. |
benweint
added a commit
that referenced
this pull request
Feb 28, 2013
RUBY-1004 Fix a Resque file descriptor leak when DontPerform exceptions are used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.