Fix empty content type and body problem#1320
Closed
jaxoncreed wants to merge 2 commits intomasterfrom
Closed
Conversation
RubenVerborgh
suggested changes
Oct 21, 2019
Contributor
RubenVerborgh
left a comment
There was a problem hiding this comment.
Thought we'd reject without content type? #1316 (comment)
Contributor
Author
|
Right, I can also do that, but after looking at how the code functioned, it turned out to work this way. Based on my interpretation of @csarven 's comment, it is also okay to allow it to create a file. Though, I'll go ahead and have it reject. |
Contributor
Author
|
Closing this as we should be merging into dev before master. Continued here: #1323 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1316