PUT copy body for contentType application/json#1346
Merged
jaxoncreed merged 2 commits intonodeSolidServer:devfrom Nov 13, 2019
bourgeoa:master
Merged
PUT copy body for contentType application/json#1346jaxoncreed merged 2 commits intonodeSolidServer:devfrom bourgeoa:master
jaxoncreed merged 2 commits intonodeSolidServer:devfrom
bourgeoa:master
Conversation
17 tasks
jaxoncreed
approved these changes
Nov 10, 2019
Contributor
jaxoncreed
left a comment
There was a problem hiding this comment.
Looks good to me. Could you adjust the pull to resolve conflicts with the dev branch?
Member
Author
|
@jaxoncreed Solved the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaxoncreed
move the steam hack inside from before call to ldp.put, to inside ldp.put.
So it is used by POST and PUT.
Checked on a docker server
npm test passed before and after commit
should solve issue #1339