Skip to content

mime-type named container gets mime-type#1363

Merged
jaxoncreed merged 5 commits intonodeSolidServer:devfrom
bourgeoa:fix#1361
Nov 22, 2019
Merged

mime-type named container gets mime-type#1363
jaxoncreed merged 5 commits intonodeSolidServer:devfrom
bourgeoa:fix#1361

Conversation

@bourgeoa
Copy link
Copy Markdown
Member

@bourgeoa bourgeoa commented Nov 19, 2019

@jaxoncreed
should solve issue #1361
checked on a docker NSS 5.2.2 + this fix

@jaxoncreed
Copy link
Copy Markdown
Contributor

Fantastic! Thanks so much for helping out.

Could you write a test for this use case?

@bourgeoa
Copy link
Copy Markdown
Member Author

I checked ldp-test.js and there is no example relating to rdf for folder, they all relate to files.
I don't think I can produce a test. I know it is the way to go when you correct a bug.

@jaxoncreed
Copy link
Copy Markdown
Contributor

Okay then. I'll have to manually review it. Thanks so much for your help!

@jaxoncreed jaxoncreed changed the base branch from master to dev November 22, 2019 17:12
Copy link
Copy Markdown
Contributor

@jaxoncreed jaxoncreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jaxoncreed jaxoncreed merged commit 697a16c into nodeSolidServer:dev Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants