Skip to content

Update @solid/oidc-rp version to 0.10.0#150

Closed
mfornos wants to merge 1 commit intonodeSolidServer:masterfrom
mfornos:master
Closed

Update @solid/oidc-rp version to 0.10.0#150
mfornos wants to merge 1 commit intonodeSolidServer:masterfrom
mfornos:master

Conversation

@mfornos
Copy link
Copy Markdown

@mfornos mfornos commented Feb 12, 2020

@solid/oidc-rp was updated to 0.10.0, this version removes the dependencies with @trust/json-document and @trust/webcrypto. A good thing because the JSON schema validator causes some problems with Content Security Policies. 😸

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 84.123% when pulling 85bb59b on mfornos:master into f8d5379 on solid:master.

@jaxoncreed
Copy link
Copy Markdown
Contributor

LGTM, just need to pull down and manually test

@michielbdejong
Copy link
Copy Markdown
Member

The dependency update is included in #163.
@mfornos can you say a bit more about the changes you made in https://github.com/solid/solid-auth-client/pull/150/files#diff-2386e1ce48920481f393939fd08834d1?

michielbdejong added a commit that referenced this pull request Jul 24, 2020
@mfornos
Copy link
Copy Markdown
Author

mfornos commented Jul 24, 2020

Sure! 😸

Changes done:

  1. The path of the import for the "oidc-rp" dependency from "lib" to "src".
  2. Fulfilled the default values for RelyingParty as expected in its constructor: https://github.com/solid/oidc-rp/blob/6d007019bd9fa54d1b2783f72018321b3891d1c6/src/RelyingParty.js#L63

michielbdejong added a commit that referenced this pull request Jul 30, 2020
* Update dependencies

* adopt fixes from #150

* Update npm outdated

* Fix flow-typed react-dom issue in demo/index.js

* got it working

* clean up

* npx npm-check-updates -u && npm install

* preact-compat -> preact/compat

* npm install @solid/oidc-rp@latest ; rm -rf node_modules ; rm package-lock.json ; npm install ; git add package-lock.json
@michielbdejong
Copy link
Copy Markdown
Member

Done! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants