Merged
Conversation
prevent breach even with relative path for getInitialCwd fix #9
Collaborator
Author
|
Thanks again! |
asylumfunk
added a commit
to asylumfunk/nodeftpd
that referenced
this pull request
Mar 7, 2014
This commit properly resolves MDTM request filenames to locations within the CHROOT jail. Previously, requests were made relative to the filesystem root (/), instead of the server root (/srv/files/from/here). This allowed users to request MDTM on potentially sensitive files (/root, /home), while simultaneously denying legitimate requests within the shared directory. Note: all filesystem calls *must* be joined with the path to the server root (pathModule.join(self.root, filename)). fix #28 ref nodeftpd@57a9e5f ref nodeftpd#5 ref nodeftpd#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent breach even with relative path for
getInitialCwd