Added missing QWidget set methods and QCursor support#76
Merged
a7ul merged 2 commits intonodegui:masterfrom Aug 31, 2019
Merged
Conversation
789c2c9 to
5447b6c
Compare
a7ul
reviewed
Aug 31, 2019
| import { Component, NativeElement } from "../../core/Component"; | ||
| import { QPixmap } from "../QPixmap"; | ||
|
|
||
| type arg = NativeElement | number | QPixmap; |
Collaborator
There was a problem hiding this comment.
I think this should be just number
We could remove both NativeElement and QPixmap from here
Contributor
Author
There was a problem hiding this comment.
This actually was left intentionally because I intend to add full support for QBitmap /QPixmap/QMasks/QCursor instances cursors, just did not have time on hand right now.
Do you think this should be removed from this PR?
a7ul
reviewed
Aug 31, 2019
| @@ -22,6 +23,7 @@ const win = new QMainWindow(); | |||
| const label = new QLabel(); | |||
| label.setText("Hello world 🧙"); | |||
| label.setInlineStyle("font-size: 20px;"); | |||
Collaborator
|
I was just about to release a new version. I think this deserves to be in there as well 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added few set methods to QWidget, QCursor definition. It will be much more useful in future, now you can use it to get and set current user pointer position.
Changed few things in demo to make it more appealing to the user (and fixed issue where window was sometimes opened under active window on Windows platform by forcing
win.setWindowState(WindowState.WindowActive);)