Skip to content

test,fs: delay unlink in test-regress-GH-4027.js#14010

Closed
jaimecbernardo wants to merge 2 commits intonodejs:masterfrom
JaneaSystems:jaimecb-H6U-node-13800
Closed

test,fs: delay unlink in test-regress-GH-4027.js#14010
jaimecbernardo wants to merge 2 commits intonodejs:masterfrom
JaneaSystems:jaimecb-H6U-node-13800

Conversation

@jaimecbernardo
Copy link
Contributor

The sequential/test-regress-GH-4027 test is flaky on Windows CI with an increased system load, failing when the watched file is unlinked before the first state of the watched file is retrieved.

After increasing the delay before unlinking and calling setTimeout after watchFile, the flakiness stopped reproducing.

Fixes: #13800

/cc @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants