build: improve shared library flags logic#1450
Closed
jbergstroem wants to merge 1 commit intonodejs:v1.xfrom
Closed
build: improve shared library flags logic#1450jbergstroem wants to merge 1 commit intonodejs:v1.xfrom
jbergstroem wants to merge 1 commit intonodejs:v1.xfrom
Conversation
Move all logic for headers/libraries for each shared library into the shared library scope - similar to how OpenSSL already works. Also, don't assume that b() returns a boolean.
Contributor
|
I can confirm this fixes #1434 |
Member
|
It would be nicer if If I read your PR right, you have to specify |
Member
Author
|
@bnoordhuis I prefer being exact since thats how other build systems work. Theres no benefit to being lazy here imo. There are so many things that break if you start playing around with configure flags. |
Member
Author
|
Closing in favour of #1454. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the commit from #1429 which fixes a bug with shared library flags. The other pull request doesn't necessarily have any issues but could benefit from a bit more review. This should be simple enough to get reviewed and merged ahead of 1.8.0
/R=@rvagg, ?