Skip to content

doc: do not advise to cancel full CI on onboarding#21977

Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-no-ci-aborting
Closed

doc: do not advise to cancel full CI on onboarding#21977
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-no-ci-aborting

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jul 25, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: #21938 (comment) and discussion below the comment.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

+5 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@refack refack refack approved these changes

@joaocgreis joaocgreis joaocgreis approved these changes

@maclover7 maclover7 maclover7 approved these changes

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@vsemozhetbyt @nodejs-github-bot @maclover7 @Trott @apapirovski @refack @joaocgreis @mmarchini @richardlau