Skip to content

test: fix flaky parallel/test-fs-write-file-typedarrays#22659

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:fix-flaky-fs-write-file-typedarrays
Closed

test: fix flaky parallel/test-fs-write-file-typedarrays#22659
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:fix-flaky-fs-write-file-typedarrays

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Sep 2, 2018

Using the same filename for different async tests could lead
to race conditions.

Example failure: https://travis-ci.com/nodejs/node/jobs/143351655

Refs: #22150

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants