Skip to content

src: fix missing deprecation assignment#23809

Closed
jasnell wants to merge 3 commits intonodejs:masterfrom
jasnell:fix-missing-deprecation-assignment
Closed

src: fix missing deprecation assignment#23809
jasnell wants to merge 3 commits intonodejs:masterfrom
jasnell:fix-missing-deprecation-assignment

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Oct 21, 2018

Missed the assignment when landing

This needs a fast-track for v11.0.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax Awaiting requested review from addaleax

+2 more reviewers

@refack refack refack approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasnell @nodejs-github-bot @vsemozhetbyt @mcollina @refack @lpinca @cjihrig @BridgeAR