doc: clarify socket and keepAliveTimeout interaction#25748
Closed
inversion wants to merge 1 commit intonodejs:masterfrom
Closed
doc: clarify socket and keepAliveTimeout interaction#25748inversion wants to merge 1 commit intonodejs:masterfrom
inversion wants to merge 1 commit intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc: clarify socket and keepAliveTimeout interaction
Socket timeouts set using the
connectionevent are replaced byserver.keepAliveTimeout when a response is handled.
Socket timeouts set in the
connectionevent are replaced after a response is sent in theresOnFinishhandlerIn this case, the socket timeout is 60 seconds until a response is sent, at which point it becomes 5 seconds (the server.keepAliveTimeout default). This bit me when working with load balancers that maintain long-lived connections.
I have added a note to the
connectionevent docs to the effect that is preferred to useserver.keepAliveTimeout.Checklist