Skip to content

worker: set stack size for worker threads#26049

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:worker-stack-overflow
Closed

worker: set stack size for worker threads#26049
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:worker-stack-overflow

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Feb 11, 2019

(The first commit is #26037.)

This is so we can inform V8 about a known limit for the stack.

Otherwise, on some systems recursive functions may lead to
segmentation faults rather than “safe” failures.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants