Skip to content

process: add --pending-deprecation to process.binding()#26500

Closed
addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax:process-binding-pd
Closed

process: add --pending-deprecation to process.binding()#26500
addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax:process-binding-pd

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2019

Print a deprecation warning for process.binding() when using
--pending-deprecation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@JungMinu JungMinu JungMinu approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+3 more reviewers

@antsmartian antsmartian antsmartian approved these changes

@devsnek devsnek devsnek approved these changes

@shisama shisama shisama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.