node: deprecate public access to process.binding#2768
Closed
vkurchatkin wants to merge 1 commit intonodejs:masterfrom
Closed
node: deprecate public access to process.binding#2768vkurchatkin wants to merge 1 commit intonodejs:masterfrom
process.binding#2768vkurchatkin wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new way to access bindings:
require('binding/module_name')and deprecatesprocess.binding. This is a logical continuation of internal modules feature. Bindings are also accessible only in builtin modules or with--expose_internalsflag.R=@nodejs/collaborators