cli: rename --loader to --experimental-loader#29752
Closed
reasonablytall wants to merge 2 commits intonodejs:masterfrom
Closed
cli: rename --loader to --experimental-loader#29752reasonablytall wants to merge 2 commits intonodejs:masterfrom
reasonablytall wants to merge 2 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
--loadercli argument to--experimental-loader. This isto clearly indicate the esm loader feature as experimental even after
esm is no longer experimental.
Also minorly alters the
--experimental-loaderdocs to say that thepassed loader can be an esm module.
An alternative to this PR is to leave things unchanged and continue to use
--experimental-modulesto allow the use of--loader, even after ECMAScript modules are unflagged. This would reduce the number of different argument schemes a hypothetical script that wraps node would need to try, as discussed here: nodejs/modules#351 (comment)Refs: nodejs/modules#351 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes