Skip to content

cli: rename --loader to --experimental-loader#29752

Closed
reasonablytall wants to merge 2 commits intonodejs:masterfrom
reasonablytall:experimental-loader-flag
Closed

cli: rename --loader to --experimental-loader#29752
reasonablytall wants to merge 2 commits intonodejs:masterfrom
reasonablytall:experimental-loader-flag

Conversation

@reasonablytall
Copy link
Contributor

Renames the --loader cli argument to --experimental-loader. This is
to clearly indicate the esm loader feature as experimental even after
esm is no longer experimental.

Also minorly alters the --experimental-loader docs to say that the
passed loader can be an esm module.

An alternative to this PR is to leave things unchanged and continue to use --experimental-modules to allow the use of --loader, even after ECMAScript modules are unflagged. This would reduce the number of different argument schemes a hypothetical script that wraps node would need to try, as discussed here: nodejs/modules#351 (comment)

Refs: nodejs/modules#351 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants