quic: continued refactoring of quic APIs#34351
Closed
jasnell wants to merge 8 commits intonodejs:masterfrom
Closed
quic: continued refactoring of quic APIs#34351jasnell wants to merge 8 commits intonodejs:masterfrom
jasnell wants to merge 8 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nodejs/quic ... this one includes a fairly extensive reworking of the
QuicStreamlifecycle, including being able to enableautoDestroy, eliminating the'abort'event and theabortedproperty, fixing up a number of bugs and internal timing issues. There's still a lot to do to validate protocol, timing, and error handling, but this is a major step in the right direction./cc @ronag
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes