Skip to content

quic: continued refactoring of quic APIs#34351

Closed
jasnell wants to merge 8 commits intonodejs:masterfrom
jasnell:quic-cleanups-7
Closed

quic: continued refactoring of quic APIs#34351
jasnell wants to merge 8 commits intonodejs:masterfrom
jasnell:quic-cleanups-7

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Jul 14, 2020

@nodejs/quic ... this one includes a fairly extensive reworking of the QuicStream lifecycle, including being able to enable autoDestroy, eliminating the 'abort' event and the aborted property, fixing up a number of bugs and internal timing issues. There's still a lot to do to validate protocol, timing, and error handling, but this is a major step in the right direction.

/cc @ronag

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants