src: expose node.http trace flag by array#48142
Closed
H4ad wants to merge 2 commits intonodejs:mainfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue raised on NodeJS Performance: nodejs/performance#81
The function
isTraceHTTPEnableis a little bit expensive, in general, that function should not even appear in the stack trace since is just to check if the trace is enabled.The solution was inspired by nodejs/performance#81 (comment) and it basically exposes the C++ pointer of the flag that tells if the HTTP trace is enabled or not by using an array.
To Reviewers
Some interesting files that could be looked to review this code:
node/deps/v8/src/builtins/builtins-trace.cc
Lines 107 to 123 in 300f68e
node/deps/v8/src/libplatform/tracing/tracing-controller.cc
Lines 295 to 344 in 300f68e
node/src/tracing/trace_event.h
Lines 62 to 73 in 300f68e