Skip to content

deps: update llhttp to 9.2.0#51719

Merged
nodejs-github-bot merged 1 commit intomainfrom
actions/tools-update-llhttp
Mar 13, 2024
Merged

deps: update llhttp to 9.2.0#51719
nodejs-github-bot merged 1 commit intomainfrom
actions/tools-update-llhttp

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Feb 11, 2024

This is an automated update of llhttp to 9.2.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 11, 2024
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 11, 2024

Review requested:

  • @nodejs/http
  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 11, 2024
mcollina
mcollina approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito marco-ippolito mentioned this pull request Feb 11, 2024
Closed
@ShogunPanda ShogunPanda force-pushed the actions/tools-update-llhttp branch from 96e8ae6 to 5380cee Compare February 13, 2024 10:14
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2024
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 14, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57081/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 16, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57140/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Feb 19, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57181/

@marco-ippolito marco-ippolito force-pushed the actions/tools-update-llhttp branch from 5380cee to 630de1c Compare February 19, 2024 15:57
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Mar 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57523/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Mar 7, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57612/

@marco-ippolito marco-ippolito force-pushed the actions/tools-update-llhttp branch from 630de1c to e31fd20 Compare March 7, 2024 14:30
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Mar 12, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57711/

@targos
Copy link
Member

targos commented Mar 12, 2024

Are there notable changes?

@marco-ippolito
Copy link
Member

marco-ippolito commented Mar 12, 2024

Are there notable changes?

support for http method QUERY, @ShogunPanda anything else?

@ShogunPanda
Copy link
Contributor

ShogunPanda commented Mar 12, 2024

Nope, that's it!

@targos targos added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @targos.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@ShogunPanda ShogunPanda force-pushed the actions/tools-update-llhttp branch from e31fd20 to a8f0da6 Compare March 13, 2024 09:34
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2024
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Mar 13, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57723/

@ShogunPanda ShogunPanda added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2024
@nodejs-github-bot nodejs-github-bot merged commit 25a6fb6 into main Mar 13, 2024
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-llhttp branch March 13, 2024 15:56
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Mar 13, 2024

Landed in 25a6fb6

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@nodejs-github-bot @rdw-msft
deps: update llhttp to 9.2.0
15e7744 
PR-URL: nodejs#51719
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
This was referenced Apr 20, 2024
Merged
Closed
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
@nodejs-github-bot @jcbhmr
deps: update llhttp to 9.2.0
0b320b1 
PR-URL: nodejs#51719
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
@marco-ippolito
Copy link
Member

marco-ippolito commented May 21, 2024 •
edited
Loading

@nodejs/releasers is it ok to land this in v20.14.0 although a major bump? it adds support for http QUERY

@richardlau
Copy link
Member

richardlau commented May 21, 2024

@nodejs/releasers is it ok to land this in v20.14.0 although a major bump? it adds support for http QUERY

Probably not because #48981 is semver-major PRs that contain breaking changes and should be released in the next major version. .

@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label May 21, 2024
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@nodejs-github-bot @marco-ippolito
deps: update llhttp to 9.2.0
5f0f96b 
PR-URL: nodejs/node#51719
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@nodejs-github-bot @RafaelGSS
deps: update llhttp to 9.2.0
eb25047 
PR-URL: #51719
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@anonrig anonrig anonrig approved these changes

@trivikr trivikr trivikr approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@nodejs-github-bot @targos @marco-ippolito @ShogunPanda @richardlau @mcollina @anonrig @trivikr @Ethan-Arrowood @aduh95