lib: fix emit warning for debuglog.time when disabled#54275
Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom Aug 27, 2024
Merged
lib: fix emit warning for debuglog.time when disabled#54275nodejs-github-bot merged 5 commits intonodejs:mainfrom
nodejs-github-bot merged 5 commits intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54265
The code of debuglog.time was executing because the internal flag
timerFlagshad the value7and the comparison was wrong, instead of checking if the enum flags were activated (2 | 4), I was just making a===comparison.Now this behavior is fixed by just doing the comparison correctly, I also added a test to track this regression.
In theory, this bug slowed down a little bit all the
requiresbut not too much since the heavy part was skipped.