vm: sync-ify SourceTextModule linkage#59000
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Aug 29, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
module.link(linker)into two synchronous stepsourceTextModule.linkRequests()andsourceTextModule.instantiate(). This allows creating vm modules andresolving the dependencies in a complete synchronous procedure.
This also makes
syntheticModule.link()redundant. The link step for aSyntheticModule is no-op and is already taken care in the constructor
by initializing the binding slots with the given export names.
This also enables (static) source phase import in
vm.SourceTextModules.Refs: #37648