Skip to content

lib: fix inspect deduplication logic#59687

Merged
nodejs-github-bot merged 11 commits intonodejs:mainfrom
miguelmarcondesf:improve-util-inspect-constructor
Sep 21, 2025
Merged

lib: fix inspect deduplication logic#59687
nodejs-github-bot merged 11 commits intonodejs:mainfrom
miguelmarcondesf:improve-util-inspect-constructor

Conversation

@miguelmarcondesf
Copy link
Contributor

@miguelmarcondesf miguelmarcondesf commented Aug 30, 2025

Fix deduplication logic for inspect output when dealing with constructor names that contain custom tags, but checking for tag followed by lowercase characters, e.g: avoiding unnecessary tag Set from a constructor extended like FooSet(3) { 1, 2, 3 } from a util.inspect(new FooSet([1, 2, 3])) but keeping it for Settings(3) [Set] { 1, 2, 3 } from a util.inspect(new Settings([1, 2, 3]))

cc @BridgeAR

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants