http: add shouldUpgradeCallback to let servers control HTTP upgrades#59824
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Sep 17, 2025
Merged
http: add shouldUpgradeCallback to let servers control HTTP upgrades#59824nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57054
Previously, you could either add no
upgradeevent handler to your HTTP server, in which case all HTTP upgrade requests were ignored, or you could add anupgradehandler and all upgrade attempts would always effectively succeed, going straight to theupgradeevent and skipping normal request handling.That can be inflexible, as there's plenty of cases where you want to support just upgrading specific requests (most commonly, specific protocols - e.g. upgrading to support websockets but not h2c).
This change adds a new
shouldUpgradeCallbackoption to HTTP servers, which receives the request details and returns a boolean that controls whether the request should be upgraded. Existing behaviour isn't changed, by making the default option value() => server.listenerCount('upgrade') > 0.