Skip to content

buffer: add end parameter#62390

Open
ronag wants to merge 1 commit intomainfrom
buffer-index-of-end
Open

buffer: add end parameter#62390
ronag wants to merge 1 commit intomainfrom
buffer-index-of-end

Conversation

@ronag
Copy link
Member

@ronag ronag commented Mar 22, 2026

To limit how far into the buffer we search without allocating an unnecessary subarray.

@ronag ronag requested review from jasnell and mcollina March 22, 2026 09:54
@ronag ronag self-assigned this Mar 22, 2026
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 22, 2026
@ronag ronag force-pushed the buffer-index-of-end branch 2 times, most recently from 6dc1d1e to f622fff Compare March 22, 2026 09:55
ronag added a commit that referenced this pull request Mar 22, 2026
@ronag
buffer: add end parameter
b57fa1f 
To limit how far into the buffer we search without allocating an
unnecessary subarray.

PR-URL: #62390
@ronag ronag force-pushed the buffer-index-of-end branch from f622fff to b57fa1f Compare March 22, 2026 09:58
ronag added a commit that referenced this pull request Mar 22, 2026
@ronag
buffer: add end parameter
b739413 
To limit how far into the buffer we search without allocating an
unnecessary subarray.

PR-URL: #62390
@ronag ronag force-pushed the buffer-index-of-end branch from b57fa1f to b739413 Compare March 22, 2026 10:08
@ronag ronag marked this pull request as ready for review March 22, 2026 10:08
ronag added a commit that referenced this pull request Mar 22, 2026
@ronag
buffer: add end parameter
5690750 
To limit how far into the buffer we search without allocating an
unnecessary subarray.

PR-URL: #62390
@ronag ronag force-pushed the buffer-index-of-end branch from b739413 to 5690750 Compare March 22, 2026 10:39
mcollina
mcollina approved these changes Mar 22, 2026
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Mar 22, 2026

CI does not seem happy

@ronag
buffer: add end parameter
ddbc9cd 
To limit how far into the buffer we search without allocating an
unnecessary subarray.

PR-URL: #62390
@ronag ronag force-pushed the buffer-index-of-end branch from 5690750 to ddbc9cd Compare March 22, 2026 13:36
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 22, 2026
@codecov
Copy link

codecov bot commented Mar 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.56701% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (7547e79) to head (ddbc9cd).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_buffer.cc 70.83% 4 Missing and 10 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62390      +/-   ##
==========================================
- Coverage   91.60%   89.68%   -1.92%     
==========================================
  Files         337      676     +339     
  Lines      140745   206742   +65997     
  Branches    21802    39603   +17801     
==========================================
+ Hits       128925   185422   +56497     
- Misses      11595    13454    +1859     
- Partials      225     7866    +7641
Files with missing lines Coverage Δ
lib/buffer.js 99.17% <100.00%> (+12.79%) ⬆️
src/node_buffer.cc 67.95% <70.83%> (ø)

... and 456 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronag ronag requested a review from mcollina March 22, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell Awaiting requested review from jasnell

@mcollina mcollina Awaiting requested review from mcollina

At least 1 approving review is required to merge this pull request.

Assignees

@ronag ronag

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ronag @mcollina @nodejs-github-bot