esm: fix source phase identity bug due to loadCache eviction#62415
Open
guybedford wants to merge 1 commit intonodejs:mainfrom
Open
esm: fix source phase identity bug due to loadCache eviction#62415guybedford wants to merge 1 commit intonodejs:mainfrom
guybedford wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
anonrig
approved these changes
Mar 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62415 +/- ##
==========================================
+ Coverage 89.68% 89.70% +0.01%
==========================================
Files 676 676
Lines 206710 206717 +7
Branches 39584 39586 +2
==========================================
+ Hits 185398 185432 +34
+ Misses 13441 13432 -9
+ Partials 7871 7853 -18
🚀 New features to boost your workflow:
|
benjamingr
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
ensurePhase()upgrading a cache source phase job to an evaluation phase job calling link -> syncLink will hit the finally block of syncLink clearing the entry from the loadCache per the cycle handling convention assuming reinsertion.When hitting this error an
ERR_MODULE_LINK_MISMATCHwas being thrown by the new test added here.The fix here is to avoid deleting in finally in syncLink when an existing entry exists.