Skip to content

crypto: fix ucs2/ucs-2/utf16le/utf-16le encoding check#8301

Closed
atstoyanov wants to merge 1 commit intonodejs:masterfrom
atstoyanov:cryptofix
Closed

crypto: fix ucs2/ucs-2/utf16le/utf-16le encoding check#8301
atstoyanov wants to merge 1 commit intonodejs:masterfrom
atstoyanov:cryptofix

Conversation

@atstoyanov
Copy link
Contributor

@atstoyanov atstoyanov commented Aug 27, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

Description of change

Normalize the encoding in getDecoder() before using it. Fixes an
AssertionError: "Cannot change encoding" when encoding is "ucs2", "ucs-2"
or "utf-16le"

Fixes: #8236

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto: getDecoder throws "AssertionError: Cannot change encoding" when encoding is "ucs2", "ucs-2" or "utf-16le".

8 participants