docs(pt): conclude the translation of the content/learn folder#3251
docs(pt): conclude the translation of the content/learn folder#3251shanpriyan merged 39 commits intonodejs:mainfrom
content/learn folder#3251Conversation
|
@TiagoDanin could you do the honors? And say what do you think about the new updates? |
|
I will wait for a proofreader of Portuguese from Portugal for this case. CC @nodejs/nodejs-pt |
@TiagoDanin it is possible that you are more familiar with the Portuguese spoken in the But by refusing to approve the pull request, you are blocking the content that This is not my first time doing this kind of contribution and I had other projects that |
|
@ovflowd could you help here? If nothing is done It risks being stuck, I am finishing the |
|
Sadly I cannot. We do require at least one other translator to approve the content. I can of course make an exception, but we should wait a little bit more. Also, you can still work on the other content, regardless of this PR :) |
0b1ccef to
f4ceac3
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
==========================================
- Coverage 66.02% 64.73% -1.29%
==========================================
Files 118 145 +27
Lines 1351 1764 +413
Branches 342 411 +69
==========================================
+ Hits 892 1142 +250
- Misses 422 573 +151
- Partials 37 49 +12 see 197 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@ovflowd I already updated the pull request with the content inside Couldn't you trust me at least a little to let me do this job without having to I kind of already have a lot of experience doing this kind of work, and there are large Below I am listing other projects that I am working on:
|
|
I think the issue at hand is that you should focus on the PR to translate only one section and let the translators have time to review those contents, and make another PR for the translation of other content. It's not about trust. It's about following policies. You're trying to force your hand, and every time you bring your other contributions to "back" up your credibility. That's not how it works. I'm going to ping @nodejs/nodejs-pt one last time, and if no review is added in 48h I'm merging this PR. Also just to be dully note, this is a translation PR; there's no rush to get this merged, landing it today vs landing next week was no impact in the user experience, besides of extra pages being translated, which is nice :) Also I wanted to make it clear, that I appreciate your contributions, I'm just not sure why of the demanding tone that you often have, I'd appreciate if you could think/reflect a little bit about that. Thanks! |
|
Also, just wanted to make it extra clear, that I understand you're experienced (even tho this shouldn't be a merit/or something you need to say) and also appreciate your contributions, for real :) |
getting-started foldergetting-started and asynchrounous-work folder
getting-started and asynchrounous-work foldergetting-started and asynchrounous-work folders
|
@ovflowd it may be that I cannot explain why my tone sounds so demanding, but the reason that makes me worry about the progress of the work is that I have observed the slowness and long delays in the processes similar to this where it is needed review from people that rarely appear and the job end up being stuck. I understand that there are worries about the quality of the content and the work that is being pushed to the main branch but I believe that there is a little too much suspicious that blocks many valuable contributions similar to this because the reviewers are not always available to permit the work go forward. So why not let the work go forward based on some basic criteria and trust the consumers to contribute in case there are some typos or content that was not well translated? I think we should remember that we are not talking about "code" where there are always reviewers to help. I really sorry for any appearance of rudeness, but I really would like to see this work going forward. 😅 |
I can assure you I would not let your PR get lost in the darkness. It could take a while, but I definitely want to support the champion of this PR (you) to get this merged. It is a matter of time and patience. The translators might be busy, or indeed just mot available, regardless, I rather wait a few weeks and get a 2nd pass, than rush to merge this PR 🙃
This is a translation PR. If you're referring to code-base translations, well, each reviewer has its standards. I happen to be very picky, and I value high quality contributions, but if you see my comments in PR, I'm all in in helping the authors to level-up their code quality whenever possible and when I get time. Sadly, I do a lot of open source work and often I cannot dedicate too much time on a single project.
This is quite the assumption. There are basic criterias. They are to get at least one existing translator (non author) to approve the PR. Sadly there's no documentation yet about the time frame. If you want this PR to get fast-tracked, you should reach the CONTRIBUTING guidelines of this repository.
Reviews are not just about code. Open Source as a whole is a collaborative and democratic work. Reviews are as important on content as in code. I hope you understand my points here. |
|
@ovflowd I really understand, and I really thank you for your support, because I believe that without you and @AugustinMauroy who approved the first pull requests of this kind, I would not have the signal I needed to know that this kind of contribution would go forward. |
|
Just a heads up that @AugustinMauroy is not a reviewer for this repository. (His approvals will not count as an approval) |
|
@ovflowd I notice the point you made, I was just mentioning |
@ovflowd I will be reviewing soon. And the sentences that i can't understand i will just ignore. |
|
Please find a preview at: https://staging.nodejs.dev/3251/ |
|
@TiagoDanin I already added the |
getting-started, asynchrounous-work, and command-line folderscontent/learn folder
|
@nazarepiedady Please do not add new files to this Pull Request. Only correction should be added here. |
|
@TiagoDanin it was recommended to me to add new files to the pull request, but do not worry there are no more, the rest will be translated through crowdin. |
|
@shanpriyan could you create a preview of the current state? |
|
Please find a preview at: https://staging.nodejs.dev/3251/ |
7fde5bb to
9765565
Compare
|
@TiagoDanin I guess @nazarepiedady updated the translations again, can you do a final pass? |
@ovflowd I just conclude the translation of the entire |
shanpriyan
left a comment
There was a problem hiding this comment.
Approving this PR as @TiagoDanin approved the translation.
Thanks for your contribution @nazarepiedady
|
Please find a preview at: https://staging.nodejs.dev/3251/ |
|
Thank you again, @nazarepiedady for the massive work! |
Description
I really love doing this work, so in this pull request, I am sending the rest
of the files in the
content/learn/getting-startedfolder, and new ones insidecontent/learn/asynchrounous-workfolder all of them translated.Related Issues
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.