This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Update contributing.md from staging to master#697
Merged
benhalverson merged 8 commits intonodejs:masterfrom May 7, 2020
benhalverson:doc-contributing
Merged
Update contributing.md from staging to master#697benhalverson merged 8 commits intonodejs:masterfrom benhalverson:doc-contributing
benhalverson merged 8 commits intonodejs:masterfrom
benhalverson:doc-contributing
Conversation
* docs(contributing.md): Added details on how to contribute #396 * docs(contributing.md): Updated the getting started section
Contributor
|
LGTM |
Member
Author
|
@designMoreWeb If you want to approve this click on the tab files changed then review changes. |
designMoreWeb
approved these changes
May 7, 2020
Contributor
designMoreWeb
left a comment
There was a problem hiding this comment.
Looks good to me great work
Contributor
Done |
giankotarola
reviewed
May 8, 2020
| * Push to your branch `git push -u origin yourbranch` | ||
| * Make a pull request against the remote branch `staging` | ||
| * Example `https://github.com/nodejs/nodejs.dev/pull/398` | ||
| * Mention @nodejs/website-redesign `/gcbrun` |
Contributor
There was a problem hiding this comment.
I think here we need to use /preview instead of /gcbrun?
Member
Author
There was a problem hiding this comment.
Oh ya forgot about that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry picking staging branch contributing.md change I made in Feb
Related Issues
#538