This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Learn-page: fix sidebar background on darkmode#955
Merged
marcustisater merged 3 commits intonodejs:masterfrom Oct 4, 2020
Merged
Learn-page: fix sidebar background on darkmode#955marcustisater merged 3 commits intonodejs:masterfrom
marcustisater merged 3 commits intonodejs:masterfrom
Conversation
|
Please find a preview at: https://staging.nodejs.dev/955/ |
manishprivet
suggested changes
Oct 4, 2020
Member
manishprivet
left a comment
There was a problem hiding this comment.
Apart from the CSS, there's also this cross which is present from the mobile menu
cc8f375 to
85a9c6a
Compare
Member
|
@manishprivet I haven't seen that issue before how did you get that? |
Member
|
@benhalverson The cross is there in the screenshots you posted at #953, you might have missed that |
Member
|
You're right. I totally didn't see that part of the issue. 🤦 |
Contributor
|
LGTM Thanks for your contribution @natandias |
Contributor
|
/preview |
|
Please find a preview at: https://staging.nodejs.dev/955/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sidebar background color when using darkmode