This repository was archived by the owner on Apr 26, 2024. It is now read-only.
did not see close button in 800 with#1017
Closed
arifemir wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
Author
|
where is the nav close button |
Member
|
🤷♂️ I have no idea what you are trying to show because you didn't provide any context. |
|
Please find a preview at: https://staging.nodejs.dev/1017/ |
Author
|
@benhalverson my os windows but no relevant break point must be ''@media (max-width: 1262px) and (min-width: 801px)'' or ''display none'' delete |
| .side-nav.side-nav--open .side-nav__open { | ||
| top: 34px; | ||
| margin-top: 0; | ||
| display: none; |
Member
There was a problem hiding this comment.
This display was set to none because the close button was visible in between the breakpoints, as mentioned here
The button was removed on purpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues