Skip to content

Feat/General improvements of the TS types #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mortaro merged 6 commits into from
Aug 27, 2022
Merged

Feat/General improvements of the TS types #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8039311
Merge pull request #248 from nullstack/unstable-next
Mortaro Aug 21, 2022
7848595
remove unnecessary attribute "name"
mayconfsousa Aug 26, 2022
dabf5be
apply prettier
mayconfsousa Aug 26, 2022
df0779b
using Record
mayconfsousa Aug 26, 2022
117a51b
remove unnecessary "undefined"
mayconfsousa Aug 26, 2022
8c26121
add bind and value to the context
mayconfsousa Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion plugins/bindable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ function transform({ node, environment }) {
} else {
node.attributes.value = object[property] ?? '';
}
node.attributes.name = node.attributes.name || node.attributes.bind;
if (environment.client) {
if (node.attributes.type === 'checkbox' || node.attributes.type === 'radio') {
node.attributes.onclick ??= noop;
Expand Down
34 changes: 21 additions & 13 deletions types/ClientContext.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import { NullstackEnvironment } from "./Environment";
import { NullstackPage } from "./Page";
import { NullstackParams } from "./Params";
import { NullstackProject } from "./Project";
import { NullstackRouter } from "./Router";
import { NullstackSettings } from "./Settings";
import { NullstackWorker } from "./Worker";
import { NullstackEnvironment } from './Environment';
import { NullstackNode } from './JSX';
import { NullstackPage } from './Page';
import { NullstackParams } from './Params';
import { NullstackProject } from './Project';
import { NullstackRouter } from './Router';
import { NullstackSettings } from './Settings';
import { NullstackWorker } from './Worker';

/**
* @see https://nullstack.app/context
*/
export type NullstackClientContext = {

export type NullstackClientContext<TProps = unknown, TBindValue = undefined> = TProps & {
/**
* Information about the document `head` metatags.
*
Expand Down Expand Up @@ -48,7 +48,7 @@ export type NullstackClientContext = {
* @scope client
* @see https://nullstack.app/context-instances
*/
instances?: Record<string, any>;
instances?: Record<string, unknown>;

/**
* It gives you information about the current environment.
Expand Down Expand Up @@ -93,11 +93,19 @@ export type NullstackClientContext = {
*
* @see https://nullstack.app/renderable-components#components-with-children
*/
children?: Readonly<Array<any>>;
children?: NullstackNode;

/**
* Custom context prop.
* Bind object.
*
* @see https://nullstack.app/two-way-bindings#complex-bindable-components
*/
[key: string]: any;
bind?: { object: Record<string, unknown>; property: string };

/**
* Bind value.
*
* @see https://nullstack.app/two-way-bindings#complex-bindable-components
*/
value?: TBindValue;
};
4 changes: 1 addition & 3 deletions types/Environment.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export type NullstackEnvironment = {

client: boolean;

server: boolean;
Expand All @@ -24,5 +23,4 @@ export type NullstackEnvironment = {
* @see https://nullstack.app/context-environment
*/
event: string;

};
};
Loading